test(node): Migrate to vitest #13606
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
reviewed
Sep 6, 2024
There was a problem hiding this comment.
I'm curious if the Node 14 tests pass here. I had to close my previous atttempt (#13458) to do the same for the core package because Vitest doesn't support Node 14. Actually not even Node 16 officially but that seemed to work at least.
|
Although now I see this comment. So we can't migrate to vitest because of Node v14? |
|
I'm afraid we're blocked on that yeah :( |
|
Closing due to Node support 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13605
I modified the long running rate-limiter tests to use fake timers too. This brought the test time down from 24 seconds to 4 seconds.